Draft
Conversation
This requires usage of `reflect.MethodByName`, which prevents DCE. This does not really matter as DCE is not smart enough to detect we don't use it, but the day we have an alternative not supporting functions call, we would be ready. Or maybe there is an alternative. Or we could use `strings.ReplaceAll()` instead.
This is a user breaking change, but I suppose not many people were using the templating system for avatar/logout URLs.
d0fbfb4 to
1490f0b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
==========================================
- Coverage 84.08% 84.05% -0.03%
==========================================
Files 227 227
Lines 13808 13820 +12
==========================================
+ Hits 11611 11617 +6
- Misses 1499 1507 +8
+ Partials 698 696 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bf326e4 to
efce01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Akvorado binaries are larger than they should be because dead code elimination is disabled because of using
reflect.MethodByNameorreflect.Method. This needs to be fixed everywhere.reflect.MethodByName()with an interface check (756d0a9)text/template