feat: List blobs/files in azure storage#3454
Merged
Merged
Conversation
Contributor
Author
|
Will pick this up again once #3459 is merged |
5a0e278 to
bb4d5c6
Compare
octonato
reviewed
Apr 9, 2026
octonato
left a comment
Contributor
There was a problem hiding this comment.
A few comments from myself
and from a friend...
No test for multi-page pagination
The core value of this PR (automatic pagination via unfoldAsync) has zero test coverage for the multi-page case. All WireMock tests return a single page with empty <NextMarker/>. A test that returns page 1 with a non-empty marker, then page 2 with an empty marker, would validate the loop actually works.
bb4d5c6 to
9d80380
Compare
9d80380 to
e7e49df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've manually run the test suite against actual azure storage.