Bumped sslcontext-kickstart to v8.3.5#3198
Merged
Conversation
|
Hi @Hakky54, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Contributor
|
I rebased this on |
Contributor
Author
|
Thank you! I am the library maintainer of the ssl library and nice to see alpakka is using it. I noticed the version was quite old and wanted to help out with resolving the compilation issues 😄 |
ennru
approved these changes
May 13, 2024
ennru
left a comment
Contributor
There was a problem hiding this comment.
Thank you for noticing and fixing.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to bump the version to the latest and make it compiling again. It will also resolve the failing auto PR from here: #3180