Fix header image centering in Mastodon theme#632
Merged
Conversation
Move the background image from .mastodon-col-header to .mastodon-col-title-row so that background-position: center correctly centers the image within the visible banner area, rather than within the full header including the chips area (which has its own white background covering the image).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #630 which noted "The focus point is not yet respected."
Summary
.mastodon-col-headerto.mastodon-col-title-rowso thatbackground-position: centercorrectly centers the image within the visible banner area (Mastodon doesn't expose a focal point for header images, vertical centering is the correct behavior)Test plan
Test in WordPress Playground