Fix crash in admin_edit_user_link for virtual subscriptions#628
Merged
Conversation
Since v4.0 friend users were migrated to virtual subscriptions (taxonomy terms). get_edit_friend_link() used new \WP_User() which fails for these virtual subscriptions, and admin_edit_user_link() called has_cap() on the resulting false/WP_Error value. - Use User::get_by_username() in get_edit_friend_link() to resolve both real users and virtual subscriptions - Guard against failed user lookups in admin_edit_user_link()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call to a member function has_cap() on falseerror on the Notification Manager pageget_edit_friend_link()usednew \WP_User()which doesn't work for virtual subscriptions (introduced in v4.0). Now usesUser::get_by_username()to resolve both real users and virtual subscriptions.admin_edit_user_link()against failed user lookups returningWP_ErrorFixes #626
Test plan
Test in WordPress Playground