Defer theme name translations to avoid early textdomain loading#625
Merged
Defer theme name translations to avoid early textdomain loading#625
Conversation
Theme names were translated via __() during registration at plugins_loaded, before translations are available. This triggered a _load_textdomain_just_in_time warning since WordPress 6.7. Register theme names as plain strings and add a friends_theme_name filter that each theme hooks to provide its translation at display time. External themes can use the same pattern.
bb6c3bb to
9332599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__()duringfriends_load_themesatplugins_loaded, before translations are available_load_textdomain_just_in_timewarning since WordPress 6.7friends_theme_nameto provide the translation at display timefriends_theme_namefilterTest plan
_load_textdomain_just_in_timenotice for thefriendsdomainTest in WordPress Playground