Strip style tags and convert iframe embeds during feed sanitization#624
Merged
Strip style tags and convert iframe embeds during feed sanitization#624
Conversation
WordPress's wp_kses_post strips <style> and <iframe> tags but leaves their text content behind. This caused ActivityPub embed CSS to appear as raw text in posts, and YouTube/Vimeo embeds to become empty divs. Introduces a custom SimplePie sanitizer that pre-processes feed content: - Removes <style> and <script> tags with their content - Converts YouTube/Vimeo/Dailymotion iframes to plain URLs for WordPress auto-embed (oEmbed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wp_kses_post(used by SimplePie's sanitizer) strips<style>and<iframe>tags but leaves their text content behind<div>wrappers with no videoIntroduces a custom SimplePie sanitizer (
SimplePie_Sanitize_KSES) that pre-processes feed content beforewp_kses_post:<style>and<script>tags with their content<iframe>embeds to plain URLs so WordPress can auto-embed them via oEmbedTest plan
<style>tags (e.g. cubicgarden.com with ActivityPub embeds) — CSS text should no longer appear in post contentTest in WordPress Playground