Fix avatar rendering in Mastodon theme and always show filters#615
Merged
Fix avatar rendering in Mastodon theme and always show filters#615
Conversation
The avatar CSS selector `.card-header .avatar` was matching both the wrapper div and the img element (WordPress adds class="avatar" to the img), causing the img to get position:absolute and its width to collapse to 0 via max-width:100%. Fix by targeting `> div.avatar` specifically. Also apply the missing friends_author_avatar_url filter in the non-status header template and prefer the stored avatar URL over get_avatar(). Remove the chips toggle button and always show the filter/chips area in the Mastodon theme. Refs #596.
Contributor
Test this PR in WordPress PlaygroundYou can test this pull request directly in WordPress Playground: This will install and activate the plugin with the changes from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.card-header .avatarmatched both the wrapper<div class="avatar">and the<img class="avatar">(added by WordPress'sget_avatar()), causing the img to getposition: absoluteand its width to collapse to 0 viamax-width: 100%friends_author_avatar_urlfilter in the non-status header template and prefer the stored avatar URL overget_avatar()fallbackRefs #596.
Test plan