Remove Spectre CSS and Sass, use plain CSS with native nesting#614
Merged
Remove Spectre CSS and Sass, use plain CSS with native nesting#614
Conversation
…esting Replace the Sass/Spectre build pipeline with hand-written CSS using native CSS nesting (supported in all modern browsers). All Spectre component imports have been replaced with equivalent CSS, keeping the same class names so no template changes are needed. - Remove spectre.css and sass from package.json devDependencies - Remove sass:compile and sass:watch build scripts - Delete friends.scss source and friends.css.map - Rewrite friends.css as plain CSS with native nesting - Convert friends-admin.css to use CSS nesting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spectre.cssandsassfrom devDependencies, removesass:compile/sass:watchscriptsfriends-admin.cssto use CSS nesting for improved readabilityTest plan
Test in WordPress Playground