Conversation
- Add a News/Welcome tab that shows version announcements as a changelog with a fixed TOC sidebar. New users see "Welcome", existing users see "News". - Show an admin notice after upgrading to a new major version, linking to the News page. Visiting the page dismisses the notice permanently. - Add news entries for versions 4.0, 3.3, 3.0, 2.4, 2.1, and 2.0 with user-facing feature highlights drawn from CHANGELOG.md. - Add migration dependency support: link_feeds_as_term_children now depends on convert_friend_users_to_subscriptions completing first. - Move link_feeds_as_term_children from 4.1.0 to 4.0.0. - Fix sanitize_usernames migration stuck as pending on alpha versions by giving it a proper status_option.
Contributor
Test this PR in WordPress PlaygroundYou can test this pull request directly in WordPress Playground: This will install and activate the plugin with the changes from this PR. |
The migration now runs during upgrade_plugin() for 4.0.0, so the status option may already be set when the test runs. Clear it first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link_feeds_as_term_childrennow depends onconvert_friend_users_to_subscriptionscompleting first.link_feeds_as_term_childrenfrom 4.1.0 to 4.0.0.sanitize_usernamesmigration stuck as pending on alpha versions by giving it a properstatus_option.Test plan
friends_welcome_versionto4.0— admin notice should appear, clicking through should dismiss itlink_feeds_as_term_childrenbeforeconvert_friend_users_to_subscriptionscompletes — should show dependency errorWordPress Playground
https://playground.wordpress.net/#{%22steps%22:[{%22step%22:%22installPlugin%22,%22pluginData%22:{%22resource%22:%22git:directory%22,%22url%22:%22https://github.com/akirk/friends%22,%22ref%22:%22news-page%22,%22refType%22:%22branch%22},%22options%22:{%22activate%22:true}}]}