Closed
Conversation
Improves the generation of auto-generated hook examples by separating hook type and function, refining function signature formatting, and updating parameter handling for better readability and PHP compatibility. Also updates the registration line to use the correct callback and parameters.
Replaces manual string concatenation for function parameters with a dedicated $param_string variable, simplifying and clarifying the construction of function signatures for extracted hooks.
Updated the hook registration line to use double quotes and curly braces for variable interpolation, ensuring correct formatting of hook and callback names.
Owner
|
I guess a good path forward is to make this configurable. |
Owner
|
Implemented in #8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably more a matter of taste, so please feel free to close this if it doesn't match your preference.
Changes in this PR would generate non-closure example callbacks.
Before
After