Merged
Conversation
The previous fix (#24) prevented the fatal error when parsing multiple @type tags, but the tag information was not being rendered in the generated documentation. This change: - Renders @type tags as sub-items in the Parameters section - Handles generic type syntax like array<string, string> - Fixes namespace prefixing for generic types Closes #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typetags as sub-items in the Parameters section of generated documentationarray<string, string>correctlyThis is a follow-up to #24 which fixed the fatal error but didn't render the type information.
Closes #23
Example output
See multiple_type_tags_hook for a live example.
Test plan
vendor/bin/phpunit- all 48 tests pass (212 assertions)vendor/bin/phpcs- no style violations