Fix namespace prefixing for built-in PHP types#19
Merged
akirk merged 2 commits intoakirk:mainfrom Sep 30, 2025
Merged
Conversation
Previously, when a namespace was configured, built-in PHP types like `null` were incorrectly prefixed with the namespace (e.g., `ActivityPub\null`). This fix: - Adds `maybe_prefix_namespace()` helper to centralize namespace logic - Excludes all built-in types: null, mixed, void, false, true, callable, resource, iterable - Adds test case to verify null and other built-in types are not prefixed
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullmaybe_prefix_namespace()to centralize namespace logicProblem
When a namespace was configured, built-in PHP types were being incorrectly prefixed. For example:
Would generate documentation showing
ActivityPub\nullinstead of justnull.Solution
maybe_prefix_namespace()helper method to handle all namespace prefixing logic in one placenull,mixed,void,false,true,callable,resource,iterableTest Plan
test_null_param_without_namespace_prefix()with fixtureActivityPub\null)null)