Prevent login redirect plugins from breaking OAuth flow#289
Merged
Conversation
Login redirection plugins (Jetpack SSO, Paid Memberships Pro, etc.) override the redirect_to parameter after login, sending users to the dashboard instead of back to the OAuth authorization screen. Hook into login_redirect at maximum priority and restore the original redirect when it contains our OAuth action parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redirect_toparameter after login, sending users to the WordPress dashboard instead of back to the OAuth authorization screenlogin_redirectat999priority and restores the originalredirect_towhen it contains ourenable-mastodon-apps-authenticateactionFixes #180
Test plan