Add quote and quoted_update notification types#287
Merged
Conversation
Mona for iPhone sends these newer Mastodon notification types in its requests, causing WordPress REST API to reject the entire request with rest_invalid_param because they were missing from the enum validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quoteandquoted_updateto thetypesandexclude_typesenum lists for the/api/v1/notificationsendpointrest_invalid_parambecause the enum validation fails on unknown valuesFixes https://wordpress.org/support/topic/mona-app-ios-rest_invalid_param-400-2/#post-18863125
Test plan
/api/v1/notifications?types[]=quotereturns a valid response instead ofrest_invalid_param