Merged
Conversation
Contributor
Author
|
I'm happy to ditch the changes to |
Owner
|
I fixed a bunch of warnings. |
Owner
|
Thank you very much! I fixed a bunch of warnings, I had already started a similar effort in #156. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used
phpcs:ignoreperhaps a little too liberally, and phpcs may be annoying now with the full WP ruleset, but we can't ship to dotcom without some lint fixes.I'm going to try to find a way to bypass lint for
vendor/bshaffer/oauth2-server-phpon wpcom though, because its code style is so radically different, although I did see indication that it's not receiving updates anyway?