Use (bounds-of-thing-at-point) for word detection#41
Merged
akicho8 merged 4 commits intoakicho8:masterfrom Aug 9, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #40
This changes the behavior when
(use-region-p). I have to admit that I don't fully understand the use case for using it with region. My understanding was, that the operation should be done on all the symbols in the region, which is what is done now. That means thatstring-inflection-erase-chars-when-regionis no longer needed.I am not sure if this breaks any use cases. If yes, it would be a good thing to document those in unit tests that don't use
(string-inflection-get-current-word)for testing as that is more an implementation detail.