Skip to content

Conversation

@H0R5E
Copy link

@H0R5E H0R5E commented Jun 23, 2021

Hey Adam,

I put this together this morning to use test suites to control the execution of the different tests rather than relying on a bespoke script with printing (yuck).

I took away all of test "test this / test that" flags in the test classes, because you should use test suites to control the execution of which tests you want to run. There are a number of ways to do it.

I also worked a bit on the path gymnastics that was going on in the regression tests to simplify the commands a bit.

The compilation tests (these names!) do not work for me, at present. For some reason it's not copying the hydrodata directories:

Error occurred in compilationTest/wecccomp and it did not run to completion.
    ---------
    Error ID:
    ---------
    ''
    --------------
    Error Details:
    --------------
    Error using bodyClass/checkinputs (line 456)
    The hdf5 file hydroData/wavestar.h5 does not exist
    
    Error in wecSimInitialize (line 145)
        body(ii).checkinputs(simu.morisonElement);
    
    Error in run (line 91)
    evalin('caller', strcat(script, ';'));
    
    Error in wecSim (line 44)
    run('wecSimInitialize');
    
    Error in compilationTest/wecccomp (line 253)
                wecSim
============================

This just increases my conviction that file copying should stop and that the wec-sim application tests are in the wrong place.

Copy link
Owner

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mat,
I like these changes and think the tests are much cleaner because of it. Thanks for cleaning up the directory changes that were in the original 'regression tests'

@akeeste akeeste merged commit 10c1242 into akeeste:ci_restructure Jun 23, 2021
@H0R5E H0R5E deleted the test_suites branch June 30, 2021 10:21
@akeeste akeeste added this to the v4.4 milestone Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants