Skip to content

Fix missing non-recurring helpers in shared traits #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cuneytsenturk merged 1 commit into from
Nov 8, 2025
Merged

Fix missing non-recurring helpers in shared traits #3317

cuneytsenturk merged 1 commit into from
Nov 8, 2025
+3 −3

Conversation

@imhayatunnabi
Copy link
Contributor

@imhayatunnabi imhayatunnabi commented Nov 5, 2025

Enhancement Done:

  • replace the isNotRecurringDocument() and isNotRecurringTransaction() guards to call their existing recurring helpers instead of the undefined isRecurring().
  • ensure every document/banking workflow can safely ask whether a record is non-recurring without triggering a fatal BadMethodCallException.

@cuneytsenturk cuneytsenturk added this to the 3.1.20 milestone Nov 8, 2025
@cuneytsenturk cuneytsenturk merged commit c1dd912 into akaunting:master Nov 8, 2025
@cuneytsenturk
Copy link
Member

cuneytsenturk commented Nov 8, 2025

Thank for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

3.1.20

Development

Successfully merging this pull request may close these issues.

2 participants

@imhayatunnabi @cuneytsenturk