[client] fix ipv6 address handling#166
Merged
akarneliuk merged 1 commit intoakarneliuk:masterfrom Mar 10, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey colleagues,
I found two issues when trying to use the gNMI client with literal IPv6 address.
The string
__target_pathwas constructed before brackets are added around the IPv6 address, causing issue with gRPC:Another issue arises when IPv6 is used and the certificate is not provided. The client attempts to retrieve the certificate from the device using
ssl.get_server_certificate().ssl.get_server_certificate()expect IPv6 address w/o enclosing brackets. With brackets it interprets the address as a domain, leading to the following error:This PR addresses both of the issues.