remove trailing comma in JTD serialisation result, fixes #2001#2028
Closed
piliugin-anton wants to merge 6 commits intoajv-validator:masterfrom
Closed
remove trailing comma in JTD serialisation result, fixes #2001#2028piliugin-anton wants to merge 6 commits intoajv-validator:masterfrom
piliugin-anton wants to merge 6 commits intoajv-validator:masterfrom
Conversation
Member
|
@piliugin-anton thank you! It needs the test that fails without this change. |
epoberezkin
reviewed
Jul 9, 2022
epoberezkin
reviewed
Jul 9, 2022
Contributor
Author
|
@epoberezkin should I write a test or you will do it? |
Member
|
@piliugin-anton it's great if you can - probably should be something similar to this one: https://github.com/ajv-validator/ajv/blob/master/spec/issues/1501_jtd_many_properties.spec.ts |
epoberezkin
reviewed
Jul 9, 2022
Contributor
Author
|
@epoberezkin Okay, I will try. Will push the changes in an hour and ping you |
Contributor
Author
|
@epoberezkin How do I write a test, when I already have a changes that returns correct result of serialization. Could you please assist me? |
Contributor
Author
|
@epoberezkin Please check if test is correct |
epoberezkin
reviewed
Jul 22, 2022
Member
|
amended in #2190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2001, #2171, #2181
What issue does this pull request resolve?
#2001
What changes did you make?
Added if condition to check whether property is first
Is there anything that requires more attention while reviewing?
Code correctness