Add esm resolver for bundlers#5070
Merged
nightwing merged 6 commits intoajaxorg:masterfrom Mar 1, 2023
Merged
Conversation
…add esm resolver generator for `ace-code` package
Codecov ReportBase: 86.20% // Head: 86.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5070 +/- ##
=======================================
Coverage 86.20% 86.21%
=======================================
Files 548 548
Lines 41704 41716 +12
Branches 6564 6565 +1
=======================================
+ Hits 35953 35965 +12
Misses 5751 5751
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# Conflicts: # src/config_test.js
nightwing
approved these changes
Feb 25, 2023
| @@ -0,0 +1,65 @@ | |||
| var fs = require("fs"); | |||
|
|
|||
| function buildResolver() { | |||
Member
There was a problem hiding this comment.
can you import these functions from Makefile.dryice.js?
Contributor
Author
There was a problem hiding this comment.
I changed code to import, hope that would work
nightwing
reviewed
Feb 26, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
setModuleLoaderfor ace config to allowace.config.setModuleLoader('ace/ext/beautify', () => import('./src-noconflict/ext-beautify.js'));dynamic imports for all extensions for bundlers (tested in Webpack 5, Parcel, Vite).prepackforace-codepackage (respecting paths)ace-builds(respecting paths)I left
webpack-resolvergenerator as it could be used for webpack 4 or less.Example builds could be found here
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.