ENG-1962: composio #547
ENG-1962: composio #547
Conversation
| from typing import Dict, Optional, Text | ||
|
|
||
|
|
||
| def create_model_from_response(response: Dict) -> Model: |
There was a problem hiding this comment.
lets create model_factory/utils and move this to there
There was a problem hiding this comment.
Would say it is better than keeping on the designated mixin?
| ) | ||
|
|
||
|
|
||
| def get_assets_from_page( |
There was a problem hiding this comment.
lets create model_factory/utils and move this to there
| raise Exception(error_message) | ||
|
|
||
|
|
||
| def get_model_from_ids(model_ids: List[str], api_key: Optional[str] = None) -> List[Model]: |
There was a problem hiding this comment.
lets create model_factory/utils and move this to there
ahmetgunduz
left a comment
There was a problem hiding this comment.
Can we please have unit and functional tests for this?
ahmetgunduz
left a comment
There was a problem hiding this comment.
ScriptModel -> UtilityModel
aixplain/enums/function_type.py
Outdated
| UTILITY = "utility" | ||
| METRIC = "metric" | ||
| SEARCH = "search" | ||
| CONNECTOR = "connector" |
There was a problem hiding this comment.
must be renamed as integration
| function: Optional[Function] = None, | ||
| is_subscribed: bool = False, | ||
| cost: Optional[Dict] = None, | ||
| function_type: Optional[FunctionType] = FunctionType.CONNECTOR, |
|
|
||
|
|
||
| class UtilityModel(Model, DeployableMixin): | ||
| class ScriptModel(Model, DeployableMixin): |
There was a problem hiding this comment.
This must be done by mistake?
| METRIC = "metric" | ||
| SEARCH = "search" | ||
| CONNECTOR = "connector" | ||
| INTEGRATION = "connector" |
There was a problem hiding this comment.
why not the value to be 'integration'?
There was a problem hiding this comment.
the value is given by model serving. There it is connector yet.
No description provided.