ENG-2161: Update Model Params for Embeddings #534
Conversation
| from aixplain.factories import ModelFactory | ||
|
|
||
| model = ModelFactory.get(embedding_model) | ||
| self.embedding_size = model.additional_info["embedding_size"] |
There was a problem hiding this comment.
self.embedding_size = model.additional_info.get("embedding_size")
There was a problem hiding this comment.
@thiago-aixplain In that case, let me update this as try catch doesnt need to check for embedding_size key retrieval. It can only check if ModelFactory.get doesnt fail
| data = super().to_dict() | ||
| data["embedding_model"] = self.embedding_model | ||
| data["embedding_size"] = self.embedding_size | ||
| data["collection_type"] = self.version.split("-", 1)[0] |
There was a problem hiding this comment.
is there any case that version is None? In case not, this is fine. Otherwise, it will crash.
There was a problem hiding this comment.
version shouldnt be none ever as it points to collection name and environment name in the format:
{index_type}-{env}-{team}-{collection_name}
|
|
||
| params = supplier_params(name=str(uuid4()), description=str(uuid4()), embedding_model=embedding_model) | ||
| index_model = IndexFactory.create(params=params) | ||
| assert index_model.embedding_model == embedding_model |
There was a problem hiding this comment.
what will happen if I add index_model = ModelFactory.get(index_model.id) before the assertions?
There was a problem hiding this comment.
@thiago-aixplain It should work the same way. IndexFactory.create also actually also returns a ModelFactory.get in the end
Add attributes to model card additional_info key:
Example Usage: