ENG-2105: persist sql data #528
Conversation
| self._validate_deployment_readiness() | ||
| previous_status = self.status | ||
| try: | ||
| if hasattr(self, "tools"): |
There was a problem hiding this comment.
This can be checked by generic type T as I initialize single agents with T = Tool
There was a problem hiding this comment.
Also if deploy method changes to raise Notimplemented error it should be handled here as well.
There was a problem hiding this comment.
I did not get this point. Is there a way to check whether "T" is a tool?
There was a problem hiding this comment.
yes you can just check isinstance(T, Tool)
ahmetgunduz
left a comment
There was a problem hiding this comment.
FAILED tests/functional/agent/agent_functional_test.py::test_sql_tool[AgentFactory] - Failed: Timeout (>30.0s) from pytest-timeout.
FAILED tests/functional/agent/agent_functional_test.py::test_sql_tool[Agent] - Failed: Timeout (>30.0s) from pytest-timeout.
FAILED tests/functional/agent/agent_functional_test.py::test_sql_tool_with_csv[AgentFactory] - Failed: Timeout (>30.0s) from pytest-timeout.
FAILED tests/functional/agent/agent_functional_test.py::test_sql_tool_with_csv[Agent] - Failed: Timeout (>30.0s) from pytest-timeout.
FAILED tests/functional/agent/agent_functional_test.py::test_agent_with_pipeline_tool[AgentFactory] - AssertionError: assert 'hello' in 'agent stopped due to iteration limit or time limit.'
FAILED tests/functional/agent/agent_functional_test.py::test_agent_with_pipeline_tool[Agent] - AssertionError: assert 'hello' in 'agent stopped due to iteration limit or time limit.'
No description provided.