Skip to content

Conversation

@xainaz
Copy link
Collaborator

@xainaz xainaz commented May 14, 2025

No description provided.

@xainaz xainaz requested a review from thiago-aixplain May 14, 2025 10:13
@thiago-aixplain thiago-aixplain changed the title fixed asset issue BUG-547: fixed asset issue May 14, 2025

def add(self, asset: T):
self.store.data[asset.id] = asset
self.store.data[asset.id] = asset.__dict__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other object parameters inside the assets? Will it be converted to dictionary too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model representation will be converted to dictionary not the parameters inside

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And is this fine for caching?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this specific model wasn't in the list we get from backend, so the factory fetches it on its own and adds it using this add function, the asset object was reaching the add function fine, with all its information, but it wasn't being stored correctly because I was just storing the model representation (which doesn't have all the information), so when it goes in the json it lost some parameters including model params. This is what I fixed, storing the asset as a dictionary now makes sure that all the parameters are extracted properly, so then they are stored correctly in the json.

@thiago-aixplain thiago-aixplain merged commit 85d0406 into development May 15, 2025
@thiago-aixplain thiago-aixplain deleted the BUG-547-model-parameters-returned-as-none branch May 15, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants