-
Notifications
You must be signed in to change notification settings - Fork 23
Custom inspector interface #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yunsukim86 the PR looks good but could you please add some functional tests for the module |
|
@shreyasXplain Thanks, I had to wait for the product decision about the UI, but now the details are decided. I'll update the PR (incl. functional tests) and ask for the review again. |
| ) | ||
|
|
||
| @classmethod | ||
| def create_auto( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be a way to have just a single create method? Automatic creation would be a parameter in the one above...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiago-aixplain It's more a product decision. Automatic creation doesn't need to consider model, params, etc...
| "plannerId": self.llm_id if self.use_mentalist else None, | ||
| "inspectorId": self.llm_id if self.use_inspector else None, | ||
| "maxInspectors": self.max_inspectors, | ||
| "inspectors": [inspector.model_dump(by_alias=True) for inspector in self.inspectors], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the by_alias=True here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's converting field names to camelCase before sending it to the backend.
…end return format
Requirements
Interface Example
Implementation Notes
Module:
ModelWithParams(abstract class)Module:
Inspector(ModelWithParams)Factory:
InspectorFactoryinspectors: List[Inspector]use_inspector,num_inspectors(these are inferred frominspectors)Next Steps