Skip to content

[codex] Add customizable search options#322

Merged
aivanovski merged 1 commit into
masterfrom
feature/customize-sesarch-options
Jun 6, 2026
Merged

[codex] Add customizable search options#322
aivanovski merged 1 commit into
masterfrom
feature/customize-sesarch-options

Conversation

@aivanovski

Copy link
Copy Markdown
Owner

Summary

  • add a Compose dialog for configuring searchable fields, search scope, matching mode, and case sensitivity
  • persist search options as JSON-backed application settings
  • apply the options in strict and fuzzy entry matchers and in searchable/recycle-bin filtering
  • expand the fake local database and add converter and fuzzy matcher tests
  • update the Android/Gradle toolchain and supporting dependencies required by the branch

Motivation

Search behavior was previously limited to a single strict/fuzzy setting. This change gives users control over which entry fields and database scopes participate in search while keeping those choices across sessions.

Validation

  • ./gradlew test
  • ./gradlew app:compileFdroidDebugKotlin
  • ./gradlew app:spotlessApply

Review note

SearchOptions.DEFAULT.restrictionScopes is currently empty, while the previous implementation always respected each group's searchable flag and the dialog model defaults the Searchable chip to enabled. Fresh or migrated settings may therefore include groups marked non-searchable until the user explicitly enables that chip. This should be resolved before marking the PR ready for review.

@aivanovski aivanovski marked this pull request as ready for review June 6, 2026 10:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3965a9ebb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aivanovski aivanovski merged commit 3c72459 into master Jun 6, 2026
7 checks passed
@aivanovski aivanovski deleted the feature/customize-sesarch-options branch June 6, 2026 13:52
@aivanovski aivanovski linked an issue Jun 6, 2026 that may be closed by this pull request
@aivanovski aivanovski added this to the 1.17.0 milestone Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option for case insensitive sorting

1 participant