Implement custom file logger#315
Conversation
99fc74f to
6430f83
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99fc74f14f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Note
Medium Risk
Touches logging and file I/O (including background coroutines and rotation), so regressions could impact log capture or file cleanup; changes are covered by new unit tests but still affect runtime diagnostics and storage.
Overview
Replaces the Treessence-based file logging with a custom Timber
FileLoggerTreebacked byFileLoggerImpl/FileSystemFacade, including async buffered writes, log rotation, and resource release after idle.Updates
LoggerInteractorto use the new logger, changes log file naming/pattern and increases max file size, and ensures file-logger trees are cleared on re-init and log file selection uses most-recently-modified.Hardens logging privacy by masking secrets in
FSCredentials.toString()(via newsubstituteAllExcept) and fixes the settings toggle to persistisFileLogEnabledbefore reinitializing logging. Adds coroutine test dependency and comprehensive unit tests for the new file logger, and updates the Gradle wrapper to8.5(plus regeneratedgradlew).Written by Cursor Bugbot for commit 588ec6c. This will update automatically on new commits. Configure here.