Skip to content

Replace browserify-istanbul with @airtap fork#308

Merged
vweevers merged 1 commit intomasterfrom
browserify-istanbul
Mar 7, 2021
Merged

Replace browserify-istanbul with @airtap fork#308
vweevers merged 1 commit intomasterfrom
browserify-istanbul

Conversation

@vweevers
Copy link
Copy Markdown
Member

@vweevers vweevers commented Mar 7, 2021

In order to include devongovett/browserify-istanbul#45.

Closes #296.

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Mar 7, 2021
@vweevers
Copy link
Copy Markdown
Member Author

vweevers commented Mar 7, 2021

Don't merge yet. nyc report doesn't produce any output, checking.

@vweevers vweevers marked this pull request as draft March 7, 2021 16:41
@vweevers
Copy link
Copy Markdown
Member Author

vweevers commented Mar 7, 2021 •
edited
Loading

Nevermind, that's unrelated and also happens with the original browserify-istanbul.

I did get output from nyc report --no-exclude-after-remap. Without that option the coverage files are filtered against a default exclude list which contains test.js. I only had a test.js file, no other files. So, no real issue.

@vweevers vweevers marked this pull request as ready for review March 7, 2021 17:06
@vweevers vweevers merged commit f6f8f9d into master Mar 7, 2021
@vweevers vweevers deleted the browserify-istanbul branch March 7, 2021 17:17
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

semver-patch Bug fixes that are backward compatible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated dependencies

1 participant

@vweevers