Skip to content

Drop node < 10#272

Merged
vweevers merged 2 commits intomasterfrom
drop-eol-node
Jan 17, 2020
Merged

Drop node < 10#272
vweevers merged 2 commits intomasterfrom
drop-eol-node

Conversation

@vweevers
Copy link
Copy Markdown
Member

We have a bunch of outdated dependencies (among them electron) that are blocked by this.

@vweevers vweevers added the semver-major Changes that break backward compatibility label Jan 11, 2020
Copy link
Copy Markdown
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vweevers
Copy link
Copy Markdown
Member Author

Build failure is nothing to worry about, small difference in sort order on newer node, will fix.

Copy link
Copy Markdown
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vweevers vweevers merged commit 3ffdf5c into master Jan 17, 2020
@vweevers vweevers deleted the drop-eol-node branch January 17, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-major Changes that break backward compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants