airspy_open_device() bugfix: use the code in airspy_list_device()#63
Merged
bvernoux merged 2 commits intoairspy:masterfrom Jun 16, 2019
Merged
airspy_open_device() bugfix: use the code in airspy_list_device()#63bvernoux merged 2 commits intoairspy:masterfrom
bvernoux merged 2 commits intoairspy:masterfrom
Conversation
Contributor
Author
|
This code also works OK on Ubuntu 18.04 LTS. |
Contributor
|
Thanks for the contribution (I have checked the code and tested it with success) |
Contributor
Author
|
@bvernoux Many thanks for merging the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the generation of SIGABRT in macOS 10.14.5 when trying to execute
airspy_open_device()with a non-zero serial number, by using the code inairspy_list_devices()to compare the serial number.This fix allows the proper execution of
airspy_open_sn()as well.