Release v2.2.0#228
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces delay loading functionality for ANE packages in the project system. The changes involve adding a delayLoad property to package dependencies, updating the application descriptor generation to support delay-loaded extensions, and refactoring list output formatting with a utility class.
- Added
ProjectPackageDependencyclass extendingPackageDependencywith adelayLoadproperty - Updated project definition to use
ProjectPackageDependencyinstead ofPackageDependency - Enhanced application descriptor to support delay-loaded extensions with XML attributes
- Introduced
ListOutpututility class for consistent tree-style output formatting - Enhanced
viewcommand to support viewing specific package versions - Added
--dependenciesflag tolistcommand for viewing all dependencies
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| version.config | Bumped minor version from 2.1 to 2.2 |
| ProjectPackageDependency.as | New class extending PackageDependency with delayLoad property |
| ProjectDefinition.as | Changed dependency type from PackageDependency to ProjectPackageDependency and added shouldDelayLoadPackage method |
| ApplicationDescriptor.as | Updated addExtension to support delayLoad parameter and refactored extension management |
| PackageDependency.as | Changed _singleLineOutput visibility to protected and formatting cleanup |
| InstallData.as | Added request and options fields for install process tracking |
| ListOutput.as | New utility class for consistent list marker output |
| ProjectGetProcess.as | Refactored to use ListOutput utility |
| ProjectDefinitionImportProcess.as | Updated to use ProjectPackageDependency |
| ApplicationDescriptorGenerationProcess.as | Integrated shouldDelayLoadPackage into extension generation |
| ViewPackageProcess.as | Enhanced to support viewing specific versions and displaying dependencies |
| PackageGetProcess.as | Refactored to use ListOutput utility |
| InstallLocalPackageProcess.as | Updated to set install request on InstallData |
| InstallFinaliseProcess.as | Updated to use ProjectPackageDependency |
| InstallDataValidationProcess.as | Refactored to use ListOutput utility |
| ViewCommand.as | Added support for version parameter in view command |
| SearchCommand.as | Refactored to use ListOutput utility |
| ListCommand.as | Added --dependencies flag and refactored to use ListOutput utility |
| InstallCommand.as | Added option processing for delay-load flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| var extensionIDs:Array = []; | ||
| for each (var extensionIDNode:XML in _xml.extensions..extensionID) | ||
| var existingDelayLoad:Boolean = false; |
There was a problem hiding this comment.
The variable existingDelayLoad is declared but never used. It's set on line 352 but the value is not utilized anywhere in the logic.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update includes some additional outputs from the
viewandlistcommands allowing:apm view PACKAGEID VERSION(specifying a version will display dependencies)apm list --depsAdditionally I have added a project config value called
delayLoadwhich allows you to set the delay load attribute for native extensions in the generated application descriptor:Updates
feat(list): add flag to list command that outputs all installed dependencies: apm list --deps (resolves #226)
feat(install, app-descriptor): initial ability to set delayLoad value for all extensions (resolves #224)
feat(view): add output of package dependencies when a specific version is viewed (resolves #225)