Remove unsed Unsafe::objectFieldOffset usage in JvmUtils#178
Merged
electrum merged 1 commit intoairlift:masterfrom Jun 13, 2025
Merged
Remove unsed Unsafe::objectFieldOffset usage in JvmUtils#178electrum merged 1 commit intoairlift:masterfrom
electrum merged 1 commit intoairlift:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated Unsafe.objectFieldOffset usage and the related bufferAddress method to eliminate warnings on newer JDKs.
- Deleted
Bufferimport and thebufferAddressmethod - Removed
ADDRESS_OFFSETfield and its reflective initialization - Cleaned up now-unused
checkArgumentimport
Comments suppressed due to low confidence (1)
src/main/java/io/airlift/slice/JvmUtils.java:18
- The import 'java.lang.reflect.Field' is now unused after removing reflection-based address offset code; consider deleting it to clean up imports.
import java.lang.reflect.Field;
dain
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent warnings when running on newer JDKs: