Fix LZ4 decompressor data leak when match offset is zero#307
Merged
martint merged 1 commit intoairlift:masterfrom Dec 10, 2025
Merged
Fix LZ4 decompressor data leak when match offset is zero#307martint merged 1 commit intoairlift:masterfrom
martint merged 1 commit intoairlift:masterfrom
Conversation
When match offset is zero, the decompressor copies pre-existing data from the decompression buffer.
dain
approved these changes
Dec 10, 2025
|
Note that the native LZ4 implementation seems to behave differently in this case and just emits 0s when the offset is 0. Even though the specification says 0 is an invalid offset. See also lz4/lz4#1631. So the question is if compatibility is a concern for this (probably) rare invalid input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When match offset is zero, the decompressor copies pre-existing data from the decompression buffer.