Skip to content

Revert "Enable failOnWarnings in maven-javadoc-plugin"#1137

Merged
wendigo merged 1 commit intomasterfrom
revert-1135-user/jwas/fail-on-warnings
Mar 10, 2026
Merged

Revert "Enable failOnWarnings in maven-javadoc-plugin"#1137
wendigo merged 1 commit intomasterfrom
revert-1135-user/jwas/fail-on-warnings

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Mar 10, 2026

Reverts #1135

There is no way to disable warnings coming from linked incubating modules (which we use in Trino: vector)

@wendigo wendigo requested a review from martint March 10, 2026 21:30
@martint
Copy link
Member

martint commented Mar 10, 2026

Can you provide an example of where/how this fails on such modules?

@wendigo
Copy link
Contributor Author

wendigo commented Mar 10, 2026 

[INFO] --- javadoc:3.12.0:jar (attach-javadocs) @ trino-spi ---
[WARNING] Javadoc Warnings
[WARNING] warning: [incubating] using incubating module(s): jdk.incubator.vector
[WARNING] warning: [incubating] using incubating module(s): jdk.incubator.vector
[WARNING] 2 warnings
[INFO] ------------------------------------------------------------------------

@wendigo
Copy link
Contributor Author

wendigo commented Mar 10, 2026

You can't suppress it. It's always a warning

@martint
Copy link
Member

martint commented Mar 10, 2026

Does that happen when the module depends on incubating modules or when the javadocs reference classes from incubating modules?

@wendigo
Copy link
Contributor Author

wendigo commented Mar 10, 2026

@martint can't tell - there is no specific location in the output:

❯ ./javadoc.sh
warning: [incubating] using incubating module(s): jdk.incubator.vector
warning: [incubating] using incubating module(s): jdk.incubator.vector
2 warnings

target/reports/apidocs on  dependabot/maven/airlift-de78842e16 [$!?] via  on ☁️
❯ cat javadoc.sh
/Users/mateusz.gajewski/.sdkman/candidates/java/25.0.2-tem/bin/javadoc -J-Xmx1024m -J-Duser.language= -J-Duser.country= @options @packages @argfile%

@wendigo
Copy link
Contributor Author

wendigo commented Mar 10, 2026

It seems from my experiments that imports are enough to trigger this

@wendigo
Copy link
Contributor Author

wendigo commented Mar 10, 2026

@martint this blocks Trino update so i need to revert this

@wendigo
Copy link
Contributor Author

wendigo commented Mar 10, 2026

cc @nineinchnick

@wendigo wendigo merged commit b2ef23c into master Mar 10, 2026
4 checks passed
@wendigo wendigo deleted the revert-1135-user/jwas/fail-on-warnings branch March 10, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martint martint martint approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wendigo @martint