Add 3D rotation support for Lottie animations#2666
Merged
gpeal merged 3 commits intoairbnb:masterfrom Oct 23, 2025
Merged
Conversation
Contributor
Author
|
Please, approval workflow and allow me to push to master branch |
Collaborator
|
@hepiao3 Could you add some test animations that validate 3d? |
gpeal
reviewed
Oct 22, 2025
Collaborator
|
Could you take a look at lottiefiles/animated_laptop_.json? It doesn't look correct in the snapshot tests |
Contributor
Author
|
The files appearing in the report diff all have rx, ry, rz attributes, and now support for these attributes has been added, so there were differences in the comparison during snapshot testing. |
|
Plese commit this changes to production. 3d rotation is not working here as well. |
Contributor
Author
|
@fmdufour Wait a moment, I am currently conducting performance testing. |
|
@hepiao3 hi, any demo could share to see what is supporting? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose is to solve the problem of Android Lottie not supporting 3D layers.