Partially revert previous change to ImageLayer.getBounds()#2623
Merged
gpeal merged 1 commit intoairbnb:masterfrom Mar 20, 2025
Merged
Partially revert previous change to ImageLayer.getBounds()#2623gpeal merged 1 commit intoairbnb:masterfrom
gpeal merged 1 commit intoairbnb:masterfrom
Conversation
The changes in airbnb#2578 set the bounds returned by `ImageLayer.getBounds()` to have 0 width and 0 height if there is no Bitmap available. This change instead calls the previous version of the logic which reads the width and height of the `LottieImageAsset`.
gpeal
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #2578 set the bounds returned by
ImageLayer.getBounds()to have 0 width and 0 height if there is no Bitmap available. This change instead calls the previous version of the logic which reads the width and height of theLottieImageAsset.