Binary compatibility with 6.5 and lower on LottieAnimation#2591
Merged
gpeal merged 1 commit intoairbnb:masterfrom Dec 15, 2024
Merged
Binary compatibility with 6.5 and lower on LottieAnimation#2591gpeal merged 1 commit intoairbnb:masterfrom
gpeal merged 1 commit intoairbnb:masterfrom
Conversation
Collaborator
b5521d9 to
7c291a2
Compare
Contributor
Author
|
Can you check again? It shouldn't show up with the hidden deprecation level. By the way, I only added compatibility to the first composable of the file, which is the method we're using. The second one is already deprecated so maybe it doesn't make sense to support it, but I'm not sure about the last one 🤔 . |
7c291a2 to
cc912dc
Compare
Collaborator
Seems to be okay! Thanks for the update |
gpeal
approved these changes
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

After #2548 was merged, the binary compatibility of the
LottieAnimationcomposable changed, making it incompatible with previous versions. This PR fixes that.Motivation: our team has a multi-repo approach and some colleagues did not update lottie for some reasons and we need to synchronize the update. With this PR we should not need to do that.
Fixes #2568