Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: airbnb/lottie-android
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.6.0
Choose a base ref
...
head repository: airbnb/lottie-android
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.6.1
Choose a head ref
  • 4 commits
  • 8 files changed
  • 3 contributors

Commits on Oct 27, 2024

  1. v6.6.1-SNAPSHOT

    gpeal committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    3965575 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Configuration menu
    Copy the full SHA
    255352b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Fix floating point errors calculating keyframe end progress (#2588)

    This fixed a really tricky bug that led to the wrong keyframe being used due to a floating point rounding error.
    Given specific composition start frames and the existing floating point rounding, you could wind up with the following situation:
    
    Keyframe 1 has an endFrame of 48 and an endProgress of 0.095051385
    Keyframe 2 has a startFrame of 48 and a startProgress of 0.09505139
    The Keyframe.containsProgress check intentionally leaves the upper end of the range open to make it unambiguous that the progress on the boundary of two keyframes should use the latter one.
    
    However, due to this floating point error, there was a gap and if the progress == the endProgress of the first keyframe, it wouldn't match either.
    
    I was able to reconstruct this specific scenario with a unit test and confirmed that this fixed it. However, it is not impossible that there are other scenarios in which this could happen. However, I would rather avoid allocating doubles for everything which is more expensive unless we find a specific repro again
    gpeal authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    5273ec6 View commit details
    Browse the repository at this point in the history
  2. v6.6.1

    gpeal committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    db4ae1d View commit details
    Browse the repository at this point in the history
Loading