[eslint config] set namedComponents option to match style guide#2501
Merged
ljharb merged 3 commits intoairbnb:masterfrom Dec 22, 2021
Merged
[eslint config] set namedComponents option to match style guide#2501ljharb merged 3 commits intoairbnb:masterfrom
namedComponents option to match style guide#2501ljharb merged 3 commits intoairbnb:masterfrom
Conversation
ljharb
reviewed
Nov 10, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a118bb9 to
4af5a31
Compare
Collaborator
|
(note: this is blocked on v7.28.0 of eslint-plugin-react being released) |
…uide Change the `namedComponents` option to `function-declaration` to match what the style guide requires. airbnb@019e0f7#r60060792
ljharb
approved these changes
Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the
namedComponentsoption tofunction-declarationto match what the style guide requires.019e0f7#r60060792
Closes #2505