Export createDynamicImportTransform and getImportSource#75
Merged
ljharb merged 1 commit intoairbnb:masterfrom Jun 18, 2019
nicolo-ribaudo:export-internals
Merged
Export createDynamicImportTransform and getImportSource#75ljharb merged 1 commit intoairbnb:masterfrom nicolo-ribaudo:export-internals
ljharb merged 1 commit intoairbnb:masterfrom
nicolo-ribaudo:export-internals
Conversation
While working on babel/babel#9552, I realized I needed two functions: - createDynamicImportTransform is basically all what this plugin does, but it can be invoked directly. - getImportSource is needed to re-use the same import argument stringifying logic for the AMD and SystemJS transforms
ljharb
requested changes
Jun 18, 2019
Collaborator
ljharb
left a comment
There was a problem hiding this comment.
Let's extract these out to separate files instead of exporting multiple things from the same file.
ljharb
previously approved these changes
Jun 18, 2019
Contributor
Author
|
Thanks! |
Collaborator
|
v2.3.0 released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd be very grateful if you could expose your internal transformation logic to use it in
@babel/plugin-proposal-dynamic-import, which will then be used in@babel/preset-env. (I will mention in the docs that, when targeting commonjs, it internally uses this plugin).Currently I'm working it around by doing this, but it is unnecessarily too hacky: link
Commit message:
If you prefer not to have
module.exportsin the source file, I could create two separate entry points:babel-plugin-dynamic-import-nodeandbabel-plugin-dynamic-import-node/utils, and export those new functions from the second one. I think that the current implementation is nicer.NOTE: This isn't blocking the Babel release, since the workaround is working for now. I can't use
getImportSourcefor AMD yet, but it is a minor problem.