Replace deprecated ssl.match_hostname method (fixes: #368)#389
Merged
jlaine merged 1 commit intoaiortc:mainfrom Jul 5, 2023
Merged
Replace deprecated ssl.match_hostname method (fixes: #368)#389jlaine merged 1 commit intoaiortc:mainfrom
ssl.match_hostname method (fixes: #368)#389jlaine merged 1 commit intoaiortc:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 4551 4542 -9
=========================================
- Hits 4551 4542 -9
☔ View full report in Codecov by Sentry. |
The standard libraries's `ssl.match_hostname` method was marked as deprecated in Python 3.10. Rather than implementing this critical piece of code ourselves, make use of the Python Cryptographic Authority's `service-identity` package. One notable behaviour change is that validation is performed *only* against the `subjectAltName` extension instead of the `commonName`. This is the same behaviour as web browsers use.
e8b1300 to
2c40dd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard libraries's
ssl.match_hostnamemethod was marked as deprecated in Python 3.10. Rather than implementing this critical piece of code ourselves, make use of the Python Cryptographic Authority'sservice-identitypackage.One notable behaviour change is that validation is performed only against the
subjectAltNameextension instead of thecommonName. This is the same behaviour as web browsers use.