Conversation
AionJayT
reviewed
May 12, 2020
Collaborator
There was a problem hiding this comment.
Could you be able to add unit test for the fix? To make sure we don't mass up the hash rate calculation.
I assume you tested with the pool software, because our CI doesn't simulate the mining pool environment.
It's better to have test case to cover it.
Moreover, the logic in the classes can be refactor better. Some of the implementation is not very clear. But we can create a ticket for that later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct hash rate calculation for rpc API "getMinerStats" and "getMinerStatistics"
Fixes Issue CP-29.
Type of change
Testing