Skip to content

Align class names with current functionality#1152

Merged
AionJayT merged 3 commits intomasterfrom
block-rename
May 8, 2020
Merged

Align class names with current functionality#1152
AionJayT merged 3 commits intomasterfrom
block-rename

Conversation

@AlexandraRoatis
Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Apr 24, 2020
@AlexandraRoatis AlexandraRoatis added this to the 1.6 milestone Apr 24, 2020
@AlexandraRoatis AlexandraRoatis self-assigned this Apr 24, 2020
AlexandraRoatis and others added 3 commits May 8, 2020 10:52
    Since the enum is part of the BlockHeader interface, it does not need
    a long name to relate to block.

    Also renamed the enum items as follows:
    - SEAL_NA to NOT_APPLICABLE
    - SEAL_POW_BLOCK to PROOF_OF_WORK
    - SEAL_POS_BLOCK to PROOF_OF_STAKE
    This remaning is meant to reduce visual confusion when dealing with
    the POS and POW seal types.
@AionJayT AionJayT merged commit a442b06 into master May 8, 2020
@AionJayT AionJayT deleted the block-rename branch May 8, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants