Conversation
AionJayT
commented
Dec 18, 2019
modAionImpl/src/org/aion/zero/impl/pendingState/AionPendingStateImpl.java
Outdated
Show resolved
Hide resolved
modAionImpl/src/org/aion/zero/impl/pendingState/AionPendingStateImpl.java
Outdated
Show resolved
Hide resolved
modAionImpl/test/org/aion/zero/impl/sync/BlockPropagationTest.java
Outdated
Show resolved
Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
AionJayT
commented
Dec 18, 2019
modAionImpl/src/org/aion/zero/impl/sync/handler/BroadcastTxHandler.java
Outdated
Show resolved
Hide resolved
…hainimpl to pendingstate.
…ace into the AionImpl and use it as a bridge between the apiServer and the pendingState
…e best block from the aionblockchain. - Also eemoved the fork0.4.0 checking into the forkUtility class and asking question from there.
- Removed the bufferEnable in the CfgTx
- Renamed flags in the pendingState - Fixed the pendingNonce method under the seedmode
- Made transaction validation in the same layer, remove the validation in the addTransactions call, remove check in the broadcast layer. - Sepecified the transaction checks for 3 different entrances in the pendingstate, keep the same executing logic in the addTransactions. - Added TxResponse types - Fixed tests
AlexandraRoatis
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue # .
Type of change
Testing