fix: CommandStart(deep_link=False) now rejects deep-link arguments#1790
Merged
JrooTJunior merged 1 commit intoApr 3, 2026
Merged
Conversation
Previously the deep_link parameter only had two effective states: False (default) accepted any /start command regardless of arguments, and True required arguments to be present. Change the default to None (accept both, backward compatible) so that False can mean "reject if deep-link arguments are present", which is the intuitive expectation when explicitly passing deep_link=False. Closes aiogram#1713 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✔️ Changelog found.Thank you for adding a description of the changes |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CommandStart to support a tri-state deep_link option so callers can explicitly reject /start commands that include a payload, while keeping the default behavior backward-compatible (accept /start with or without args).
Changes:
- Change
CommandStart.deep_linkfrombooltobool | NonewithNoneas the new default (accept any/start). - Implement explicit rejection of deep-link args when
deep_link=False. - Add/adjust tests and a Towncrier changelog fragment for the new behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
aiogram/filters/command.py |
Implements tri-state deep_link logic and enforces “no args” when deep_link=False. |
tests/test_filters/test_command.py |
Adds coverage for /start with/without args across CommandStart() and CommandStart(deep_link=False), and updates __str__ expectation. |
CHANGES/1713.bugfix.rst |
Documents the behavior change and the backward-compatible default shift to None. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JrooTJunior
approved these changes
Apr 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1790 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 607 607
Lines 14425 14430 +5
=========================================
+ Hits 14425 14430 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1713
CommandStart(deep_link=False)now correctly matches only/startwithout arguments, rejecting/start <payload>.Problem
The
deep_linkparameter had only two effective states:False(default) — accepted any/startcommand, with or without argumentsTrue— required arguments to be presentThere was no way to say "match only if there is no deep-link payload."
Solution
Change
deep_linkto a three-state parameter (None | bool):None(new default)/startFalsedefaultTrueFalseTest plan
tests/test_filters/test_command.py/start+CommandStart(deep_link=False)→ True/start test+CommandStart(deep_link=False)→ False/start+CommandStart()→ True (backward compat)CHANGES/1713.bugfix.rst🤖 Generated with Claude Code