Skip to content

Add support for State type in scenes methods #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JrooTJunior merged 2 commits into from
May 9, 2025
Merged

Add support for State type in scenes methods #1685

JrooTJunior merged 2 commits into from
May 9, 2025

Conversation

@andrew000
Copy link
Contributor

@andrew000 andrew000 commented Apr 28, 2025

#1684

Description

Add support for State type in scenes methods like goto, enter, get

Calm down MyPy

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Apr 28, 2025
@github-actions
Copy link

github-actions bot commented Apr 28, 2025 •
edited
Loading

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (482629a) to head (81f3c67).
Report is 2 commits behind head on dev-3.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1685   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          568       568           
  Lines        13341     13341           
=========================================
  Hits         13341     13341
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
aiogram/fsm/scene.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JrooTJunior JrooTJunior merged commit 72dd709 into aiogram:dev-3.x May 9, 2025
23 checks passed
@andrew000 andrew000 deleted the scene-goto-input-type branch May 9, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

Assignees

No one assigned

Labels

3.x Issue or PR for stable 3.x version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrew000 @JrooTJunior