Switch the test job to astral-sh/setup-uv#1715
Merged
Merged
Conversation
Mirrors aio-libs/propcache#243, which routed the ``test`` and CodSpeed benchmark jobs through ``astral-sh/setup-uv`` with ``uv pip install``. The same change was omitted from the companion yarl PR (aio-libs#1711); this picks it up.
The codspeed runner reported missing profiling data with uv's managed Python; restore actions/setup-python on the benchmark path and limit this PR to the test job.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Switches the CI
testjob in.github/workflows/ci-cd.ymlfrom
actions/setup-pythonpluspiptoastral-sh/setup-uvplusuv pip install.UV_PYTHON_PREFERENCE: only-managedis scoped to thesetup-uvstep (matching aio-libs/aiohttp#12629). Pre-releaseinterpreters (alpha, beta, rc,
-dev, or~-pinned latest)skip the wheel cache so each run resolves freshly against the
current snapshot.
The CodSpeed benchmark workflow (
reusable-codspeed.yml) isleft on
actions/setup-python; an earlier revision of this PRswapped it too, and the CodSpeed runner reported missing
profiling data on the resulting uv-managed interpreter, so that
change was reverted.
Are there changes in behavior for the user?
No. CI-only change; end-user-visible behavior of
yarlisunaffected.
Is it a substantial burden for the maintainers to support this?
No.
Related issue number
N/A; follow-up to #1711.
Checklist
CHANGES/folderAgent run details (optional, for reviewers)
Drafted with Claude Code (Opus 4.7); reviewed by @bdraco.
Local verification:
pre-commit run --files .github/workflows/ci-cd.yml CHANGES/1715.contrib.rstpasses (yamllint, actionlint,GHA workflow validators, codespell, timeout-minutes check).
make doc-spellingproduces only the seven pre-existingmisspellings already on
master; the newCHANGES/1715.contrib.rstfragment is clean.Scope intentionally narrow:
testjob inci-cd.ymlmoves touv. Thecibuildwheeljob and the tox-driven jobs added in Integrate tox-dev/workflow's reusable-tox.yml #1711are untouched.
reusable-codspeed.ymlwas rolled back after a previousrevision lost CodSpeed profiling data on the uv-managed
interpreter.