Enforce towncrier requirements for docs to fix CI#1052
Merged
bdraco merged 1 commit intoaio-libs:masterfrom Aug 14, 2024
Merged
Enforce towncrier requirements for docs to fix CI#1052bdraco merged 1 commit intoaio-libs:masterfrom
bdraco merged 1 commit intoaio-libs:masterfrom
Conversation
bdraco
approved these changes
Aug 14, 2024
Member
bdraco
left a comment
There was a problem hiding this comment.
Thanks @commonism
I started looking into this yesterday but ran out of time. Appreciate the fix
Member
|
Looks like Codecov is stuck. Will try close reopen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with the release of towncrier 24.7 the CI/CD regulary fails as the linter does not work.
sphinxcontrib-towncrier does have an upper boundary for the towncrier version and is incompatible to 24.7.
c.f. sphinx-contrib/sphinxcontrib-towncrier#92
Installing tc 23.11 for docs to avoid getting 24.7.